Fix - Tabs component#446
Merged
Merged
Conversation
enguerranws
force-pushed
the
fix/tabs-component-with-async-tabs
branch
from
September 12, 2025 09:13
eb800a8 to
ae2e642
Compare
Collaborator
|
Can't beleve I wrote such shit code. Thank you for the fix @enguerranws! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that at certain times, when we have tabs loaded asynchronously, the selected tab is not the correct one. For example, if we have 3 tabs, the second one is loaded asynchronously, and we have selected the third one, in the end, the second tab is the one selected in the interface.
I made a more simple approach (using useMemo instead of useState + useEffect), which works fine with both sync and async generated tabs.